fix indexin for new Dict syntax #8622
Conversation
|
If it broke and no one noticed I feel a test should be added. |
|
I just did that for the profiler in fbd4463. |
|
Ok I'll add some basic test tonight after work, I just wanted to fix this quickly as my work depends on this. Is "test/arrayops.jl" the right destination for such a test? |
fix indexin for new Dict syntax
| function pr8622() | ||
| x=[1,3,5,7] | ||
| y=[5,4,3] | ||
| return indexin(x,y) |
There was a problem hiding this comment.
Doesn't matter, but this could easily be a one-liner.
There was a problem hiding this comment.
Yes indeed. I wanted to make it look more fancy then it is :D. Thanks for merging.
On 08 Oct 2014, at 23:56, Jeff Bezanson notifications@github.com wrote:
In test/arrayops.jl:
@@ -902,3 +902,11 @@ function i7197()
ind2sub(size(S), 5)
end
@test i7197() == (2,2)
+
+# PR #8622 and general indexin test
+function pr8622()
- x=[1,3,5,7]
- y=[5,4,3]
- return indexin(x,y)
Doesn't matter, but this could easily be a one-liner.—
Reply to this email directly or view it on GitHub.
The new Dict syntax broke
indexin. I think this fix is ok? Should there be a test for this?